chore(cli): remove dead hand-rolled HTTP code#41
Merged
Conversation
After --http moved to IDAHTTPServer, delete the superseded run_http_mode_legacy and its now-unused machinery: HttpPendingCommand + the command queue, http_queue_and_wait, query_result_to_json, build_cli_http_help_text, and the g_http_server pointer (http_signal_handler now just sets the stop flag). No behavior change; --http re-verified live (status, format=csv, graceful shutdown).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up cleanup to #40. Now that
--httpruns onIDAHTTPServer, removes the supersededrun_http_mode_legacyand its unused machinery (HttpPendingCommand+ command queue,http_queue_and_wait,query_result_to_json,build_cli_http_help_text,g_http_server).http_signal_handlernow just sets the stop flag. ~360 lines of dead code removed; no behavior change (--httpre-verified live).