Add ability to use custom labels in SpecFlow plugin #284
Conversation
|
|
Allure.Features/allureConfig.json
Outdated
| "owner": "^owner:?(.+)", | ||
| "severity": "^(normal|blocker|critical|minor|trivial)" | ||
| "severity": "^(normal|blocker|critical|minor|trivial)", | ||
| "label": "(.+)\\((.+)\\)" |
There was a problem hiding this comment.
To use same semantics as other labels better to make regex like this: "^label:([\w]+):(.+)"
There was a problem hiding this comment.
Also, you can use internal property in PluginConfiguration this way:
internal string label => "^label:([\\w]+):(.+)";
There was a problem hiding this comment.
And I'm not sure about
internal string label => "^label:([\w]+):(.+)";
Do we really need this? In this case we can't customize a regex pattern in the config file.
| }; | ||
| } | ||
|
|
||
| public static Label CustomLabel(string key, string value) |
There was a problem hiding this comment.
There is no need to add new method, you can simply use new Label { name = key, value = value } in SpecFlow adapter directly
|
Hello guys! We are very glad to see your contributions. Sounds funny because I pushed almost the same changes recently (f5ac293) :) Your PR looks really nice, just need to make some changes on review. 🍕 ❤️ |
4 participants
Context
Can't use Layer, AllureId fields with SpecFlow Plugin
Checklist