Default package name processing for JUnit4 listener #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # allure-junit4/src/main/java/io/qameta/allure/junit4/Tag.java # allure-junit4/src/test/java/io/qameta/allure/junit4/FeatureCombinationsTest.java
baev
requested changes
Aug 15, 2017
|
|
||
| private String getPackage(final Class<?> testClass) { | ||
| return testClass.getPackage().getName(); | ||
| if (testClass.getPackage() != null) { |
Member
There was a problem hiding this comment.
Optional.of(testClass)
.map(::getPackage())
.map(::getName())
.orElse("");
baev
requested changes
Aug 15, 2017
Member
baev
left a comment
baev
left a comment
There was a problem hiding this comment.
Could you please add unit test for a such case?
Contributor
Author
|
Ок |
baev
approved these changes
Aug 16, 2017
Member
|
@jkttt thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When test is placed in default package, allure fails testrun with NullPointerException
Added null pointer processing and empty package name for that case
P.s.
I havent provided tests for that case, because default package class can not be imported, and therefore can not be run from test.
Checklist