Skip to content

Attach screenshots and page source based on selenide config.#198

Closed
rosolko wants to merge 1 commit into
allure-framework:masterfrom
rosolko:selenide_config
Closed

Attach screenshots and page source based on selenide config.#198
rosolko wants to merge 1 commit into
allure-framework:masterfrom
rosolko:selenide_config

Conversation

@rosolko
Copy link
Copy Markdown

@rosolko rosolko commented Feb 12, 2018

//: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)

Context

Checklist

@simple-elf
Copy link
Copy Markdown
Contributor

I think this (#202) solution is better. Because with Configuration.screenshots = true; both selenide and allure will save screenshots (or/and page html source). Files will dublicate in allure-results folder, and in /report/com/class/ folder.

In projects there I'm using Selenide to Allure integration I set Configuration.screenshots = false;

@baev
Copy link
Copy Markdown
Member

baev commented Feb 16, 2018

fixed via #202

@baev baev closed this Feb 16, 2018
@baev
Copy link
Copy Markdown
Member

baev commented Feb 16, 2018

@rosolko thanks anyway!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enum class cast exception when using varargs generic constant parameter in step

3 participants