Added @Disabled tests handling#222
Conversation
|
@sidelnikovmike seems like there're couple of PMD violations... I'd assume it failed on AllureJunit5.java - line 87 (missing final keyword on input args)... please run |
| } | ||
|
|
||
| @Override | ||
| public void executionSkipped(TestIdentifier testIdentifier, String reason) { |
There was a problem hiding this comment.
quality plugin will fail on missing final for inputs
There was a problem hiding this comment.
I'll look at checks, thanks
| .withStage(Stage.FINISHED) | ||
| .withStatus(SKIPPED); | ||
|
|
||
| methodSource.ifPresent(source -> { |
There was a problem hiding this comment.
just wondering, why do you need to create a local variable methodSource, if it's used only once?.. 89 line could be merged with this one I believe...
There was a problem hiding this comment.
Don't be so wondering :) such things sometime happens.
Thanks, I'll fix this
|
I'll now look at fail |
| // "ISSUE-1", "ISSUE-2", "ISSUE-3", | ||
| // "TMS-1", "TMS-2", "TMS-3" | ||
| // ); | ||
| // } |
|
Summon @baev |
|
@eroshenkoam or @baev could you look at PR? |
baev
left a comment
baev
left a comment
There was a problem hiding this comment.
Code looks ok.
As far as I know some people likely will not like to see disabled tests in the report.
In case you run only one test group will other tests reported as skipped?
|
@baev I think no. Group - another class? If you run only group - other tests will not run at all |
I mean running tests using tags |
|
@sidelnikovmike @sskorol thanks! 👍 |
3 participants
Context
This pull request fixes problem, that tests with annotation
@Disablednot shown in report.Allure shows skipped test only in case of assumption.
Checklist