Add support for Cucumber-JVM 3 #225
Merged
Merged
Conversation
baev
requested changes
Jun 12, 2018
| @@ -0,0 +1,309 @@ | |||
| package io.qameta.allure.cucumber3jvm; | |||
|
|
|||
| import cucumber.api.*; | |||
| /** | ||
| * Parts of package-private cucumber.runtime.formatter.TestSourcesModel needed for Allure 2 adapter. | ||
| */ | ||
| public final class CucumberSourceUtils { |
Member
There was a problem hiding this comment.
lets make it package private or move to internal package
| @bad | ||
| Scenario: Bad scenario with background | ||
| When I add a to b | ||
| Then result is 16 No newline at end of file |
Member
There was a problem hiding this comment.
make sure all the files ends with new line
…vate, added new line at end of feature files
Contributor
Author
|
Added requested changes |
Member
Contributor
|
@baev @noronhaa looks good to me in general Although I do have suggestion for future improvement/refactoring - we need to think on how we can reduce code duplication here as I can see that some helper and utils classes were just copied for new adapter Maybe we can introduce common shared module with such classes etc., but scope of this changes should be outside this PR. I'll have a look at it when we will have hands on new major Allure 3 version |
baev
approved these changes
Jun 13, 2018
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[//]: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Usage:
Checklist