JsonUnit has been added#236
Merged
Merged
Conversation
viclovsky
force-pushed
the
allure-jsonunit
branch
from
a5a9f5b to
8c4ee95
Compare
viclovsky
force-pushed
the
allure-jsonunit
branch
from
8c4ee95 to
7ac438b
Compare
viclovsky
force-pushed
the
allure-jsonunit
branch
from
7ac438b to
fa09b00
Compare
baev
requested changes
Aug 10, 2018
| dependencies { | ||
| compile project(':allure-attachments') | ||
| compile('net.javacrumbs.json-unit:json-unit:2.0.0.RC1') | ||
| compile('com.google.code.gson:gson') |
Member
There was a problem hiding this comment.
we have jackson in deps, can we use it instead?
| <html> | ||
| <head> | ||
| <meta http-equiv = "content-type" content = "text/html; charset=UTF-8"> | ||
| <script type='text/javascript' src="https://cdn.jsdelivr.net/npm/jsondiffpatch/dist/jsondiffpatch.umd.min.js" charset="utf-8"></script> |
Member
There was a problem hiding this comment.
lets include minified version directly to template in order to make it work offline
| overflow: auto; | ||
| } | ||
|
|
||
| #visualdiff { |
Member
There was a problem hiding this comment.
use class selectors instead if possible
…e unnecessary css styles
baev
approved these changes
Aug 13, 2018
Member
|
ty! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[//]: # (
. Thank you so much for sending us a pull request!
.
. Make sure you have a clear name for your pull request.
. The name should start with a capital letter and no dot is required in the end of the sentence.
. To link the request with isses use the following notation: (fixes #123, fixes #321)
.
. An example of good pull request names:
. - Add Russian translation (fixes #123)
. - Add an ability to disable default plugins
. - Support emoji in test descriptions
)
Context
Allure integration for JsonUnit has been added.
JsonPatchMatcher is extension of JsonUnit matcher, that generates pretty html attachment for differences based on json diff patch.
Example was added. Screenshot is presented below.
Also added
withRequestTemplateandwithResponseTemplateto customise templates for rest-assured.Checklist