chore: improve interop between prettier and eslint#29
Merged
Conversation
This, in particular, disables unused-vars in favor of the TS variant of the rule, and sets quote-props'es consistent-as-needed option.
8 tasks
baev
approved these changes
Dec 19, 2024
2 tasks
Viperwow
added a commit
that referenced
this pull request
Apr 18, 2025
- Add `retriesCounter` to the `plugin-awesome` - Add `retriesCount` to the `web-awesome`
epszaw
added a commit
that referenced
this pull request
Apr 22, 2025
epszaw
pushed a commit
that referenced
this pull request
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quotePropsto"consistent"to match ESLint'squote-propsrule.avoidEscapetotruefor ESLint's@stylistic/quotesrule to match Prettier's formatting behavior when dealing with strings with double quote characters inside (e.g.,'"foo"="bar"').Other changes:
ignoreRestSiblingstotruefor ESLint's@typescript-eslint/no-unused-varsrule to prevent false positives in situations like this:foowould affect the behavior.eslint-config-preactand../../.eslintrc.cjsextend entries in the ESLint config ofweb-awesometo prioritize the project settings over the ones in the preact preset. Otherwise, the plainno-unused-varsrule would be used instead of the TypeScript version. Some other rules like@stylistic/quoteswould also be misconfigured with regard to the project scope.