Skip to content

Update to ECS 4.0.0 stable #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2018
Merged

Update to ECS 4.0.0 stable #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,9 @@ We use [EasyCodingStandard] to define and execute checks created for both [PHP-C
## Installation

```bash
composer require --dev lmc/coding-standard:dev-master symplify/easy-coding-standard:^4.0@alpha symplify/coding-standard:^4.0@alpha symplify/package-builder:^4.0@alpha symplify/token-runner:^4.0@alpha symplify/better-reflection-docblock:^4.0@alpha
composer require --dev lmc/coding-standard:dev-master
```

ℹ️ Because we currently depend on `@alpha` version of [EasyCodingStandard], all of its `@alpha` dependencies must temporarily
also be explicitly required with their stability flag.

## Usage

1. Create `easy-coding-standard.yaml` file in root directory of your project and import the LMC code-style rules:
Expand Down Expand Up @@ -53,7 +50,6 @@ You can configure EasyCodingStandard via `parameters` section of your `easy-codi
- skip specific check from some file(s) or directories (via [`skip`](https://github.com/Symplify/EasyCodingStandard#ignore-what-you-cant-fix))
- disable whole check (via [`exclude_checkers`](https://github.com/Symplify/EasyCodingStandard#exclude-checkers))


## Changelog
For latest changes see [CHANGELOG.md](CHANGELOG.md) file. We follow [Semantic Versioning](http://semver.org/).

Expand Down
3 changes: 1 addition & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"description": "Coding standard used in LMC projects",
"type": "library",
"license": "MIT",
"minimum-stability": "alpha",
"prefer-stable": true,
"authors": [
{
Expand All @@ -12,7 +11,7 @@
}
],
"require": {
"symplify/easy-coding-standard": "4.0.x"
"symplify/easy-coding-standard": "^4.0.0"
},
"require-dev": {
"j13k/yaml-lint": "^1.1",
Expand Down
11 changes: 1 addition & 10 deletions easy-coding-standard.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
imports:
# Import path when this package is installed as dependency
- { resource: '../../easy-coding-standard/config/psr2.yml', ignore_errors: true }
# Import path when this package is being used directly (eg. during development)
- { resource: 'vendor/symplify/easy-coding-standard/config/psr2.yml', ignore_errors: true }
- { resource: '%vendor_dir%/symplify/easy-coding-standard/config/psr2.yml' }
Copy link

@TomasVotruba TomasVotruba Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So sexy 1-liner 💯 👙


services:
# Class and Interface names should be unique in a project, they should never be duplicated
Expand Down Expand Up @@ -200,9 +197,3 @@ parameters:

# There could be more than one space after star (eg. in Doctrine annotations)
PHP_CodeSniffer\Standards\Squiz\Sniffs\Commenting\DocCommentAlignmentSniff.SpaceAfterStar: ~

# Skip non-PSR2 rules incorrectly added by ECS (https://github.com/Symplify/Symplify/issues/696)
PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.LineAfterClose: ~
PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.NoLineAfterClose: ~
PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.SpaceBeforeCloseBrace: ~
PHP_CodeSniffer\Standards\Squiz\Sniffs\WhiteSpace\ControlStructureSpacingSniff.SpacingAfterOpenBrace: ~