Skip to content

Fix non aligned timestamp and utc bug - #94

Merged
bart1 merged 1 commit into
mainfrom
59-datetime-behaviour
Jul 7, 2025
Merged

Fix non aligned timestamp and utc bug#94
bart1 merged 1 commit into
mainfrom
59-datetime-behaviour

Conversation

@bart1

@bart1 bart1 commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Fix #59 by working for date time

@PietrH

PietrH commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

I'm not sure when I'll get to this review, probably not this week.

@bart1
bart1 requested a review from peterdesmet July 7, 2025 12:35
@bart1

bart1 commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator Author

I think this should also resolve #61

@bart1 bart1 linked an issue Jul 7, 2025 that may be closed by this pull request
2 tasks
@bart1
bart1 marked this pull request as ready for review July 7, 2025 12:43

@peterdesmet peterdesmet left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test code, but assume it's good.

@bart1

bart1 commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator Author

Did not test code, but assume it's good.

Living on the edge ;)

Given the tests work I think it is fine!

@bart1
bart1 merged commit c31dab9 into main Jul 7, 2025
@bart1
bart1 deleted the 59-datetime-behaviour branch July 7, 2025 12:45
bart1 pushed a commit that referenced this pull request Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document single datetime vs interval in get_pvol and get_vpts Change datetime behaviour in get_vpts()

3 participants