test: cover the trust boundary — sandbox hardening argv, verify clean-room, config precedence#151
Merged
Merged
Conversation
…-room, config precedence The modules that ARE the security/verification story had the least coverage. test_sandbox.py makes the "never weaken hardening flags" rule executable; test_verify.py pins the clean-room replay as the only source of "verified"; test_config.py pins flags > toml > defaults precedence. Closes #57. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
3 tasks
alphacrack
added a commit
that referenced
this pull request
Jul 18, 2026
Internal quality release: the 70-test trust-boundary suite (#151, sandbox hardening argv, clean-room verify, config precedence) and CI gates (#152, coverage ratchet at 80, mypy at zero). No user-facing behavior changes. Version bumped in lockstep across pyproject.toml, CITATION.cff (0.6.4 / 2026-07-18), and CHANGELOG.md. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #57. 70 new tests (291 → 361, still <3s, zero Docker/network) covering the modules that ARE the security/verification story:
subprocess.runrecords every docker argv. One named test per hardening flag (--cap-drop ALL,--security-opt no-new-privileges, memory/cpus/pids limits, network mode) plus an exact full-argv pin — removing a hardening flag now fails a test that names it. Also env/mount argv, exec/copy/destroy error paths, and all fourdocker_socket_gidfallbacks.False/0winning), toml coercion, missing-file error. Unknown/typo'd keys silently dropping is pinned as current behavior with#84comments — behavior change stays in config: misspelled TOML keys are silently dropped — add extra='forbid' #84.Zero
src/changes. One observation for the record:copy_in/copy_outlack the_startedguardexechas — tests pin the resulting error path; a guard would be a separate tiny PR if wanted.The grounding invariant
🤖 Generated with Claude Code