Bump govuk-components from 5.2.1 to 5.3.0

[dependabot]

Bumps govuk-components from 5.2.1 to 5.3.0.

Release notes

Sourced from govuk-components's releases.

Version 5.3.0

• Upgrade to govuk-frontend 5.3.0 - this involved removing the now-redundant role attribute from the header, footer and nav components #523
• Upgrade tabs component to have a default title when nothing is specified, thanks @​frankieroberto #521
• Add two extra slots to the footer so content can be injected before/after the meta items #519
• Various minor dependency updates #522, #524, #525

Version 5.2.2

• add the List helper to ease the creation of GOV.UK style lists. #509, #520 Thanks @​frankieroberto!
• fix a bug where data-module: "govuk-button" was missing from #govuk_button #513 Also add custom branding and double click prevention #514 - thanks @​misaka ❤️

Commits

• 5c0ec80 Release version 5.3.0
• 2eb90ed Bump express from 4.18.2 to 4.19.2 in /guide (#524)
• c9400ae Bump express from 4.18.2 to 4.19.2 in /guide
• c33caf6 Bump axios and govuk-prototype-kit in /guide (#525)
• 8419308 Bump axios and govuk-prototype-kit in /guide
• a5769ba Upgrade to GOV.UK Frontend 5.3.0 (#523)
• 1780117 Remove role attribute from header, footer and nav
• a42da37 Upgrade to govuk-frontend 5.3.0
• d4814e7 Add before and after links slots to footer (#519)
• a32dc85 Add before and after links slots to footer
• Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[jamie-o-wilkinson]

Hmm the tests fail for this. I'm going to press on with the other dependabot PRs and I'll come back to this.

[DavidBiddle]

I don't actually think the govuk-components library should be overriding our data-module value like this - I'd expect ours to take precedence. I'm on support tomorrow so I'll raise an issue with them and try and figure out what's going on

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[jamie-o-wilkinson]

I don't actually think the govuk-components library should be overriding our data-module value like this - I'd expect ours to take precedence. I'm on support tomorrow so I'll raise an issue with them and try and figure out what's going on

Oh interesting, thanks for looking into this more @DavidBiddle. So we should be able to override the default for govuk_button?

[DavidBiddle]

@jamie-o-wilkinson Yeah, I think so. For other HTML attributes I think it either adds to the existing attribute or overrides their value with ours, so I'd expect it to do one of those here. But it looks like it's trying to do both - the raw HTML it's generating is:

<button class="govuk-button" data-module="govuk-button" new_tab="false" data-module="sign-in-button" type="submit">Sign in</button>

i.e. it has 2 data-module attributes, which is invalid HTML so browsers discard the second one. Based on the way it treats other attributes I think I'd expect it to generate one of these:

<button class="govuk-button" new_tab="false" data-module="sign-in-button" type="submit">Sign in</button>

<button class="govuk-button" new_tab="false" data-module="govuk-button sign-in-button" type="submit">Sign in</button>

[DavidBiddle]

Made an issue for this in the govuk-components repo, about to raise a PR for it: x-govuk/govuk-components#529

Edit - PR here: x-govuk/govuk-components#530

[DavidBiddle]

Have put this into draft. If that govuk-components PR gets merged I think we can close this and wait for the next release to roll out via dependabot. If it gets declined we can make this one ready for review again and merge it in as-is.

[dependabot]

A newer version of govuk-components exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

[DavidBiddle]

@dependabot recreate

[dependabot]

Superseded by #1082.