Skip to content

Make sending confirmation emails async#1896

Merged
theseanything merged 2 commits intomainfrom
theseanything/make-confirmation-emails-async
Feb 23, 2026
Merged

Make sending confirmation emails async#1896
theseanything merged 2 commits intomainfrom
theseanything/make-confirmation-emails-async

Conversation

@theseanything
Copy link
Contributor

@theseanything theseanything commented Feb 11, 2026

Switches the FormSubmissionService to use the ActiveJob to send the confirmation email, instead of doing during request time. This should improve the reliability of form submission. This softens the dependency on Notify's availibilty.

@theseanything theseanything force-pushed the theseanything/make-s3-submission-async branch 2 times, most recently from c1333d0 to e8630dd Compare February 13, 2026 11:13
@theseanything theseanything force-pushed the theseanything/make-confirmation-emails-async branch from 34021bf to dfd1d29 Compare February 13, 2026 11:21
Base automatically changed from theseanything/make-s3-submission-async to main February 16, 2026 09:49
This adds an ActiveJob to create the confirmation email for a given Submission.
Switches the FormSubmissionService to use the ActiveJob to send the confirmation email, instead of doing during request time. This should improve the reliability of form submission. This softens the dependency on Notify's availibilty.
@theseanything theseanything force-pushed the theseanything/make-confirmation-emails-async branch from dfd1d29 to 4726ca2 Compare February 18, 2026 08:31
@theseanything theseanything marked this pull request as ready for review February 18, 2026 08:32
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@theseanything theseanything requested a review from a team February 23, 2026 10:22
Copy link
Contributor

@stephencdaly stephencdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected locally. Left some non-blocking comments but feel free to merge.

@theseanything theseanything added this pull request to the merge queue Feb 23, 2026
Merged via the queue into main with commit 33559c8 Feb 23, 2026
6 checks passed
@theseanything theseanything deleted the theseanything/make-confirmation-emails-async branch February 23, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants