Skip to content

Reintroduce making sending confirmation emails async #1929

Merged
theseanything merged 2 commits intomainfrom
theseanything/revert-revert-make-confirmation-emails-async
Feb 26, 2026
Merged

Reintroduce making sending confirmation emails async #1929
theseanything merged 2 commits intomainfrom
theseanything/revert-revert-make-confirmation-emails-async

Conversation

@theseanything
Copy link
Contributor

@theseanything theseanything commented Feb 24, 2026

Previously we had to rollback a PR to Make sending confirmation emails async: #1896

This was due to a failing E2E testing in our staging environment.

The problem was caused as the Notify API Key environment variable wasn't present in our forms runner queue worker task. This has since been added here: alphagov/forms-deploy#1998

Tested in dev (where same problem was replicated)

@theseanything theseanything force-pushed the theseanything/revert-revert-make-confirmation-emails-async branch from 8f21788 to 3ebaf13 Compare February 24, 2026 17:12
@theseanything theseanything requested review from a team and stephencdaly February 25, 2026 11:22
…ing/make-confirmation-emails-async"

This reverts commit c210dd6, reversing
changes made to 2246d2c.
We no longer send the email at request time, this attribute is only
available in the job context.
@theseanything theseanything force-pushed the theseanything/revert-revert-make-confirmation-emails-async branch from 90f97b0 to 390a0b4 Compare February 25, 2026 11:43
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@theseanything theseanything added this pull request to the merge queue Feb 26, 2026
Merged via the queue into main with commit 573afac Feb 26, 2026
6 checks passed
@theseanything theseanything deleted the theseanything/revert-revert-make-confirmation-emails-async branch February 26, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants