Reintroduce making sending confirmation emails async #1929
Reintroduce making sending confirmation emails async #1929theseanything merged 2 commits intomainfrom
Conversation
8f21788 to
3ebaf13
Compare
We no longer send the email at request time, this attribute is only available in the job context.
90f97b0 to
390a0b4
Compare
|
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |



Previously we had to rollback a PR to Make sending confirmation emails async: #1896
This was due to a failing E2E testing in our staging environment.
The problem was caused as the Notify API Key environment variable wasn't present in our forms runner queue worker task. This has since been added here: alphagov/forms-deploy#1998
Tested in dev (where same problem was replicated)