Update pagination macro descriptions #5881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`href` is only required if the item is not an ellipsis (like `number`). Minor tweaks to the wording.
romaricpascal
approved these changes
May 9, 2025
Member
romaricpascal
left a comment
romaricpascal
left a comment
There was a problem hiding this comment.
Cheers for the update @frankieroberto ! The change looks good to me, but I'll let @seaemsi or @calvin-lau-sig7 give the second approval needed for its merge as it's content related 😊
Contributor
Author
|
@seaemsi @calvin-lau-sig7 any chance of a second review? 🙏 |
seaemsi
approved these changes
May 21, 2025
Contributor
Author
|
@romaricpascal @seaemsi is this mergeable now? |
querkmachine
pushed a commit
that referenced
this pull request
Jun 6, 2025
Update pagination macro descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When porting this component across to the NHS design system, I noticed a couple of minor inconsistencies with the macro option descriptions.
hrefwas marked as required butnumberwas not marked as required. For both, they’re technically optional as they’re not required if the item is an ellipsis. This tries to make that clearer.Have also add a clarification to the
visuallyHiddenTextto try and make it clearer that there is some default text, and you’d only need to set it if you wanted to change this.