Skip to content

Update package references in README.#340

Merged
lablnet merged 1 commit intoalphazframework:masterfrom
Maikuolan:patch-1
Dec 6, 2020
Merged

Update package references in README.#340
lablnet merged 1 commit intoalphazframework:masterfrom
Maikuolan:patch-1

Conversation

@Maikuolan
Copy link
Copy Markdown
Member

Replaces softhub99/zest_framework (marked as abandoned at Packagist) with zest/framework (Zest's current package identity).

Replace 'softhub99/zest_framework' with 'zest/framework'.
@peter279k
Copy link
Copy Markdown
Member

The failed test is as follows:

There were 2 errors:

1) Framework\Tests\Archive\GzipTest::testExtract
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen

/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:14

2) Framework\Tests\Archive\GzipTest::testCompress
gzopen(/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/Zest.png.gz): Failed to open stream: `9' is not a valid mode for fopen

/home/runner/work/Zest_Framework/Zest_Framework/src/Archive/Adapter/Gzip.php:87
/home/runner/work/Zest_Framework/Zest_Framework/Tests/Archive/GzipTest.php:26

According to the gzopen function usage, the default $mode 9 is not valid for second argument on gzopen() function.

@peter279k
Copy link
Copy Markdown
Member

The problematic code is available here and it causes failed Gzip tests:

@peter279k peter279k assigned peter279k and Maikuolan and unassigned peter279k Dec 5, 2020
@Maikuolan
Copy link
Copy Markdown
Member Author

According to the gzopen function usage, the default $mode 9 is not valid for second argument on gzopen() function.

Good catch. :-)

But, seeing as this particular PR only deals with the README file, if possible, let's open a new, separate PR to deal with the Gzip test failures. 👍

@Maikuolan
Copy link
Copy Markdown
Member Author

@Maikuolan
Copy link
Copy Markdown
Member Author

I'll create a new PR now for the Gzip tests.

@Maikuolan
Copy link
Copy Markdown
Member Author

Done (#341).

Copy link
Copy Markdown
Member

@lablnet lablnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lablnet lablnet merged commit ef59893 into alphazframework:master Dec 6, 2020
@Maikuolan Maikuolan deleted the patch-1 branch December 6, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants