Attempt to fix Gzip failures.#341
Merged
lablnet merged 2 commits intoalphazframework:masterfrom Dec 6, 2020
Maikuolan:patch-2
Merged
Attempt to fix Gzip failures.#341lablnet merged 2 commits intoalphazframework:masterfrom Maikuolan:patch-2
lablnet merged 2 commits intoalphazframework:masterfrom
Maikuolan:patch-2
Conversation
Member
Author
|
StyleCI complaints. '-.- One sec. |
Member
Author
|
Tests look good now. :-) |
peter279k
reviewed
Dec 6, 2020
|
|
||
| $filename = $destination; | ||
| if ($outfile = gzopen($filename, $mode)) { | ||
| if ($outfile = gzopen($filename, 'wb'.$mode)) { |
Member
There was a problem hiding this comment.
I think it should verify the compression mode before calling the gzopen function.
According to the gzcompress reference, the compression level range should be from 0 to 9.
Member
There was a problem hiding this comment.
I think it should verify the compression mode before calling the
gzopenfunction.
agreed 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(See comments at #340).