Xiaoya refactor block#43
Merged
dylanmcreynolds merged 17 commits intoApr 20, 2026
Merged
Conversation
This was referenced Apr 16, 2026
dylanmcreynolds
requested changes
Apr 16, 2026
taxe10
reviewed
Apr 17, 2026
taxe10
left a comment
There was a problem hiding this comment.
Just a couple of very minor comments. Looks good.
dylanmcreynolds
approved these changes
Apr 17, 2026
Contributor
|
I'm ok to merge this. Great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main changes of this PR
Use the arroyopy block YAML format to replace the
processor_cli_tpx.py.Define
XPSResultStart, sent fromXPSOperatortoXPSWSResultPublisher, with the workflow:running_meanfor flush n as follows, and I check with Johannes that the calculation is correct in this splash_timpix issue:LSE, and everything works well.Issues with this PR
The splash_timepix simulator currently generates one flush per scan, which does not cause issues for

LSE, since the model inference time is around 0.5 s per image on my MacBook. However, Johannes mentioned that in real experiments it is possible to generate hundreds or thousands of flushes. In that case,LSEmay run into performance issues. We may need to add some accumulation logic inArroyoXPSto limit the data frequency sent toLSE.