call publisher start#18
Merged
dylanmcreynolds merged 2 commits intoApr 17, 2026
Merged
Conversation
dylanmcreynolds
approved these changes
Apr 15, 2026
Collaborator
|
This is great. I did similar with listeners, but forgot about publishers. There's a linting error and one failed test. When you fix these we can merge this. Thanks! |
Contributor
Author
Thanks. I use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added code to call
start()in the publisher. It looks likestart()is now being called for the operator and the listener as well.This could cause a problem because
LSEWSResultPublisherconnects to the listener within itsstart()method, see LSE companion PR and arroyoXPS companion.