Changed prettier workflow to actually apply changes#2806
Changed prettier workflow to actually apply changes#2806george-gca wants to merge 4 commits intoalshedivat:mainfrom
Conversation
Signed-off-by: George Araújo <george.gcac@gmail.com>
✅ Deploy Preview for relaxed-lollipop-b6bc17 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: George Araújo <george.gcac@gmail.com>
george-gca
force-pushed
the
new_prettier_workflow
branch
from
0203b6c to
ed1e8b0
Compare
Signed-off-by: George Araújo <george.gcac@gmail.com>
Signed-off-by: George Araújo <george.gcac@gmail.com>
alshedivat
left a comment
alshedivat
left a comment
There was a problem hiding this comment.
LGTM, thanks for simplifying the workflow
| - name: Install Prettier 💾 | ||
| run: npm install --save-dev --save-exact prettier @shopify/prettier-plugin-liquid |
There was a problem hiding this comment.
looks like prettier code formatter fails. you may need to keep this step.
|
It is failing in the checkout code part, and honestly idk why. I even asked for help in actions/checkout#1326 (comment). |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
I'll try to come back to this later. Last time that I checked it was failing on the pull action, which was out of my control. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
2 participants
No description provided.