fix: harden profile reuse and uniformize profile display and reuse#45
Conversation
|
The semantic title check is failing because Suggested title:
|
|
The title is fixed now. The remaining
- expect(JSON.parse(result.stdout).profile.user.email).toBe("agent@x.io");
+ expect(JSON.parse(result.stdout).profile.principal.email).toBe("agent@x.io");I verified the related non-service checks locally: The full |
The profile-display refactor left ConfigureOptions.org half-removed: resolveConfigureProfile and the interactive wizard still read options.org, breaking typecheck. Finish the removal — org is not a configuration option — by threading it as an explicit argument to configureRunSet, which still derives the auto profile name and persists organization_slug. Drop managementWhoamiOperation, orphaned when the refactor removed `profile show`'s live-whoami call (profile show is now stored-only) — which knip flagged as an unused export. Align the lakehouse integration e2e with that same change: `profile show` no longer enriches identity via /whoami, so assert the stored profile shape (profile.name) instead of the removed profile.user.email. This suite isn't run by the local --quick gate (needs the mock server), so the refactor missed it. tests/helpers: force NO_COLOR in the black-box CLI subprocess so citty's colorized arg-validation errors don't break plain-text assertions locally (CI already sets CI=1). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
88c3424 to
3fa5d84
Compare
There was still remnance of
profile inspectandprofile showI kept the inspect one as it looked simpler
I also added a heuristic to explicitly reuse a profile if it's not configured yet and special-case ENV-supplied credentials into a pseudo-profile