-
Notifications
You must be signed in to change notification settings - Fork 91
Remove random_state arg from get_pipelines in AutoMLSearch #1719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
1ddfa6f
93a2911
4839d27
bf8a77c
5747dcb
9ee2622
babb2ea
5d63a5b
4bd86cb
693a462
e5230ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2165,3 +2165,16 @@ def test_automl_pipeline_params_kwargs(mock_fit, mock_score, X_y_multi): | |
| if 'Decision Tree Classifier' in row['parameters']: | ||
| assert 0.1 < row['parameters']['Decision Tree Classifier']['ccp_alpha'] < 0.5 | ||
| assert row['parameters']['Decision Tree Classifier']['max_depth'] == 1 | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("random_state", [0, 1, 9]) | ||
| @patch('evalml.pipelines.MulticlassClassificationPipeline.score') | ||
| @patch('evalml.pipelines.MulticlassClassificationPipeline.fit') | ||
| def test_automl_pipeline_random_state(mock_fit, mock_score, random_state, X_y_multi): | ||
| X, y = X_y_multi | ||
| automl = AutoMLSearch(X_train=X, y_train=y, problem_type='multiclass', random_state=random_state, n_jobs=1) | ||
| automl.search() | ||
|
|
||
| for i, row in automl.rankings.iterrows(): | ||
| if 'Base' not in list(row['parameters'].keys())[0]: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. O same question as other PR LOL, why the check for
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The baseline pipeline isn't initialized with a |
||
| assert automl.get_pipeline(row['id']).random_state == random_state | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So fresh and so clean. Awesome.