feat: remove property setters and custom fields on uninstall (backport #311)#312
Merged
barredterra merged 2 commits intoversion-14-hotfixfrom Oct 27, 2025
Merged
Conversation
(cherry picked from commit 09adbdd) # Conflicts: # .github/workflows/ci.yml # README.md
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
🎉 This PR is included in version 0.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the app's uninstallation process by ensuring that all customizations made by the app are cleanly removed. The main changes focus on expanding the uninstall logic to handle custom fields and property setters.
Uninstallation enhancements:
banking/uninstall.py, added logic to remove custom fields associated with the app by iterating over those defined inget_custom_fields.This is an automatic backport of pull request feat: remove property setters and custom fields on uninstall #311 done by Mergify.