provide the option for transport to take sources as evaluators#313
Merged
provide the option for transport to take sources as evaluators#313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport relies on capabilities around Amanzi's DomainFunctions to provide non-linear source terms. Domain Functions could have been evaluators, but are not.
This has both advantages (lower memory footprint) and disadvantages (no ability to visualize or observe individual components of the source terms; style mismatch with the rest of ATS).
This PR implements SOME of the domian functions of Amanzi as evaluators. It then swaps to using those in transport. Now, transport source terms may be provided in either or both ways:
Geochemistry still must be provided as a DomainFunction. Standard sources independent of mole fraction may be provided either way.
The ATS input converter changes some of these to evaluators.