Skip to content

provide the option for transport to take sources as evaluators#313

Merged
ecoon merged 5 commits intomasterfrom
ecoon/df_as_eval
Jul 9, 2025
Merged

provide the option for transport to take sources as evaluators#313
ecoon merged 5 commits intomasterfrom
ecoon/df_as_eval

Conversation

@ecoon
Copy link
Copy Markdown
Collaborator

@ecoon ecoon commented Jul 7, 2025

Transport relies on capabilities around Amanzi's DomainFunctions to provide non-linear source terms. Domain Functions could have been evaluators, but are not.

This has both advantages (lower memory footprint) and disadvantages (no ability to visualize or observe individual components of the source terms; style mismatch with the rest of ATS).

This PR implements SOME of the domian functions of Amanzi as evaluators. It then swaps to using those in transport. Now, transport source terms may be provided in either or both ways:

  • using the PK's "source terms" sublist --> DomainFunctions
  • using the PK's "has source term", "source term key" to provide sources as an evaluator.

Geochemistry still must be provided as a DomainFunction. Standard sources independent of mole fraction may be provided either way.

The ATS input converter changes some of these to evaluators.

@ecoon ecoon merged commit cf13df2 into master Jul 9, 2025
1 check passed
@ecoon ecoon deleted the ecoon/df_as_eval branch July 9, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant