fix(npm): change glob preventing GunDataNode.d.ts#1241
Merged
amark merged 1 commit intoamark:masterfrom May 25, 2022
Merged
Conversation
Owner
|
@ShaunSHamilton good catch! Thank you 👏 ⚡ ⭐ . I think long long time ago there were some data.json files but this is much safer overall. Thanks for the improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes from cd45008433759cb65476e42eabc8b076d53a9f6d caused the GunDataNode.d.ts file from being included in the NPM package.
Can be confirmed by using:
This fix assumes the only file unwanted is
stats.radata. However, this also causes the following files to be included:I left them as included, because other test files are included in the package. However, in my opinion, the npm package should not include test files 🤷♂️