You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
BranchProtectionAssessor (src/agentready/assessors/testing.py) is registered in create_all_assessors() but its assess() method unconditionally returns not_applicable. It has never contributed to any assessment score.
The assessor's own docstring describes the intended implementation:
This is a stub implementation that will return not_applicable until GitHub API integration is implemented.
What it should check
Per the existing criteria in the assessor:
Required status checks on the default branch
Required review approvals before merging
Force push prevention
Branch update requirements (branch must be up to date before merging)
Implementation notes
The project already has GitHub integration infrastructure in src/agentready/github/
The assessor is Tier 4 (Advanced) with default_weight=0.005 — low weight, low risk
Should gracefully degrade to skipped when no GitHub token is available or the repo is not on GitHub (e.g., local-only repos, GitLab)
Background
BranchProtectionAssessor(src/agentready/assessors/testing.py) is registered increate_all_assessors()but itsassess()method unconditionally returnsnot_applicable. It has never contributed to any assessment score.The assessor's own docstring describes the intended implementation:
What it should check
Per the existing criteria in the assessor:
Implementation notes
src/agentready/github/default_weight=0.005— low weight, low riskskippedwhen no GitHub token is available or the repo is not on GitHub (e.g., local-only repos, GitLab)branch_protectionis also absent fromdefault-weights.yaml(tracked in Fix default-weights.yaml: dead key, missing entries, and scoring drift #403) — that should be resolved alongside or before thisAcceptance criteria
assess()returns a realpass/failfinding when GitHub API access is availableskipped(notnot_applicable) when no token or non-GitHub remote is detectedbranch_protectionadded todefault-weights.yaml(see Fix default-weights.yaml: dead key, missing entries, and scoring drift #403)Opened by Claude Code under the supervision of Bill Murdock.