feat: add pdm.lock to recognized lockfiles

[mantomas]

Description

Adding pdm.lock to recognized Python lockfiles

Changes Made

• Added pdm.lock to the lockfiles list in src/agentready/assessors/stub_assessors.py

Testing

• tested against local project which utilizes PDM Python package manager

Summary by CodeRabbit

• Bug Fixes
  • Fixed assessment of repositories using PDM package manager to correctly identify them as having strict, pinned-version dependency lock files instead of falling back to manual dependency checks.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 7a1587ed-33f6-4344-919e-924ebd3d2fab

📥 Commits

Reviewing files that changed from the base of the PR and between 312c99a and 4ede2d3.

📒 Files selected for processing (1)

• src/agentready/assessors/stub_assessors.py

---

📝 Walkthrough

Walkthrough

DependencyPinningAssessor now recognizes pdm.lock as a strict dependency lock file, enabling proper assessment of PDM-managed Python projects alongside Poetry and pip-tools repositories.

Changes

PDM Lockfile Detection

Layer / File(s)	Summary
PDM strict lockfile recognition src/agentready/assessors/stub_assessors.py	pdm.lock is added to strict_lock_files so PDM-managed repositories are properly assessed as having strict, pinned-version dependencies.

Possibly Related PRs

• ambient-code/agentready#143: Both PRs update the same file to expand lockfile detection logic by adding newly recognized lockfiles.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title follows the Conventional Commits format with type 'feat' and clearly describes the main change: adding pdm.lock to recognized lockfiles.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

✨ Simplify code

• Create PR with simplified code

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

• Generate code and open pull requests
• Plan features and break down work
• Investigate incidents and troubleshoot customer tickets together
• Automate recurring tasks and respond to alerts with triggers
• Summarize progress and report instantly

Built for teams:

• Shared memory across your entire org—no repeating context
• Per-thread sandboxes to safely plan and execute work
• Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[natifridman]

PR #436 Review: feat: add pdm.lock to recognized lockfiles

Verdict: Approve

This is a correct and welcome addition. PDM is a well-established Python package manager (PEP 582 / PEP 621), and its pdm.lock file contains exact pinned versions — it rightfully belongs in the strict_lock_files list.

Suggestions (non-blocking)

1. Ordering — group with Python lock files

Currently pdm.lock is appended after go.sum, but all other Python lock files are grouped together (lines 53–55). Moving it next to uv.lock would be more consistent:

"poetry.lock",  # Poetry
"Pipfile.lock",  # Pipenv
"uv.lock",  # uv
"pdm.lock",  # PDM        # <-- here instead of after go.sum

2. Comment casing

The comment says # pdm but every other entry uses the tool's proper name with capitalization (# Poetry, # Pipenv, # uv, # Rust, # Ruby, # Go). PDM is typically written uppercase — should be # PDM.

3. Test coverage (nice-to-have)

The existing test suite covers package-lock.json, poetry.lock, requirements.txt, and Cargo.lock individually, but no test covers pdm.lock. A short test similar to test_python_poetry_lock would prevent future regressions if someone accidentally removes the entry. Not blocking, but worth adding.

What looks good

• Correct file — stub_assessors.py:59 is the right place
• pdm.lock is auto-managed with exact versions, so strict_lock_files (not manual_lock_files) is the correct classification
• No logic changes needed — the existing assessor flow handles it automatically
• The commit message follows conventional commits format

---

This review was generated by Claude Code.