docs: flag bootstrap overwrite behavior as not yet implemented#450
Conversation
The user guide and developer guide both claim bootstrap never overwrites existing files, but only CONTRIBUTING.md and CODE_OF_CONDUCT.md are currently protected. Add warnings linking to #449 so users know the guarantee is not yet fully enforced. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
📝 WalkthroughWalkthroughTwo documentation updates clarify the current state of file overwrite protection in the bootstrap process. The developer guide now states that ChangesFile Overwrite Behavior Documentation
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/user-guide.md`:
- Line 101: Update the contradictory statements so both occurrences convey the
same current behavior: replace the sentence that reads "Never overwrites
existing files (⚠️ [not yet fully implemented]..., currently only
`CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected)" and the line saying
bootstrap “never overwrites files by design” with a single consistent phrasing
that reflects the actual state (e.g., "Bootstrap aims to avoid overwriting files
but full overwrite protection is not yet implemented — currently only
`CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected; see issue `#449`"), and
keep the link to the issue; ensure both the earlier mention (the one from the
diff) and the later bootstrap claim use that exact updated text.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: aef0178e-7c69-4116-a929-44442cc0e234
📒 Files selected for processing (2)
docs/developer-guide.mddocs/user-guide.md
|
|
||
| - Use `--dry-run` to preview changes | ||
| - Never overwrites existing files | ||
| - Never overwrites existing files (⚠️ [not yet fully implemented](https://github.com/ambient-code/agentready/issues/449), currently only `CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected) |
There was a problem hiding this comment.
Resolve contradictory overwrite guidance in the same page
Line 101 says overwrite protection is not fully implemented, but Line 331 still says bootstrap “never overwrites files by design.” That conflict can lead users to run bootstrap with incorrect safety assumptions.
Suggested doc fix
-**"File already exists" (Bootstrap)** — Bootstrap never overwrites files by design. Remove existing files first if regenerating.
+**"File already exists" (Bootstrap)** — Overwrite protection is not yet fully implemented (see [`#449`](https://github.com/ambient-code/agentready/issues/449)); currently only `CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected. Use `--dry-run` and review `git status` before applying changes.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@docs/user-guide.md` at line 101, Update the contradictory statements so both
occurrences convey the same current behavior: replace the sentence that reads
"Never overwrites existing files (⚠️ [not yet fully implemented]..., currently
only `CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected)" and the line
saying bootstrap “never overwrites files by design” with a single consistent
phrasing that reflects the actual state (e.g., "Bootstrap aims to avoid
overwriting files but full overwrite protection is not yet implemented —
currently only `CONTRIBUTING.md` and `CODE_OF_CONDUCT.md` are protected; see
issue `#449`"), and keep the link to the issue; ensure both the earlier mention
(the one from the diff) and the later bootstrap claim use that exact updated
text.
📈 Test Coverage Report
Coverage calculated from unit tests only |
|
🎉 This PR is included in version 2.39.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
docs/user-guide.mdnoting that the "never overwrites existing files" guarantee is not yet fully implemented (onlyCONTRIBUTING.mdandCODE_OF_CONDUCT.mdare protected)_file_exists()reference indocs/developer-guide.mdto reflect the actual_write_file()method and its current behaviorTest plan
Submitted by Bill Murdock with assistance from Claude Code.
Summary by CodeRabbit