merge queue: embarking main (26be0f9) and #998 together#1009
Closed
mergify[bot] wants to merge 4 commits intomainfrom
Closed
merge queue: embarking main (26be0f9) and #998 together#1009mergify[bot] wants to merge 4 commits intomainfrom
mergify[bot] wants to merge 4 commits intomainfrom
Conversation
The frontend VTEAM_VERSION env var was hardcoded in the deployment
manifest and required imperative "oc set env" patching after deploy.
ArgoCD reverts imperative changes on every sync, so the UI always
showed the stale default ("v0.0.7") on declaratively-managed clusters.
Embed the version in the backend binary at compile time via Go
ldflags and expose it through a new "GET /api/version" endpoint.
The frontend version route now proxies to the backend instead of
reading a local env var, making the version correct regardless of
deployment tool.
The backend becomes the single source of version truth for all
consumers (UI, CLI, API clients). Local builds get a short git SHA
from "git describe --tags --always --dirty", CI stage deploys get
the full commit SHA, and release deploys get the semver tag.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The ubi9/go-toolset base image sets "ENV VERSION=1.24.6", which shadows the Dockerfile ARG of the same name. The backend binary was getting the Go toolchain version instead of the git ref. Use the "AMBIENT_" prefix to avoid collisions with base image environment variables. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The "local-reload-backend" and "_build-and-load" targets were building the backend image without the version build arg, so those paths would always show "dev" in the UI. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (26be0f9) and #998 are embarked together for merge.
This pull request has been created by Mergify to speculatively check the mergeability of #998.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]Required conditions to stay in the queue:
#approved-reviews-by >= 1[🛡 GitHub repository ruleset ruleprotect-main]#approved-reviews-by>=1#changes-requested-reviews-by = 0[🛡 GitHub repository ruleset ruleprotect-main]#changes-requested-reviews-by=0check-success=End-to-End Testscheck-success=test-local-dev-simulationcheck-success=validate-manifests