fix(vertex): switch CLOUD_ML_REGION default from us-east5 to global#1453
Merged
mergify[bot] merged 2 commits intomainfrom Apr 23, 2026
Merged
fix(vertex): switch CLOUD_ML_REGION default from us-east5 to global#1453mergify[bot] merged 2 commits intomainfrom
mergify[bot] merged 2 commits intomainfrom
Conversation
Remove the backend override that forced `global` → `us-east5` in getAnthropicClient(). The original constraint (claude-haiku-4-5 not available in global region) no longer applies. Update the control-plane config default, MPP overlay, CI workflow, scripts, and docs to use `global` consistently — aligning with the production ConfigMap that already sets CLOUD_ML_REGION=global. Closes #1451 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for cheerful-kitten-f556a0 canceled.
|
Contributor
Merge Queue Status
This pull request spent 9 seconds in the queue, including 1 second running CI. Required conditions to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAnthropicClient()that forcedCLOUD_ML_REGION=globalback tous-east5— the original constraint (claude-haiku-4-5 not available in global) no longer appliesglobalinstead ofus-east5CLOUD_ML_REGION: "global"Changes
components/backend/handlers/display_name.goglobal → us-east5override; default toglobalwhen env var is emptycomponents/ambient-control-plane/internal/config/config.gous-east5toglobalcomponents/manifests/overlays/mpp-openshift/ambient-control-plane.yamlglobal.github/workflows/pull-reviews.ymlgcp_regiontoglobal.github/scripts/model-discovery.pyscripts/setup-vertex-kind.shdocs/components/backend/handlers/display_name_test.goglobalTest plan
CLOUD_ML_REGION=globalin stagingCloses #1451
🤖 Ambient Session