THROWAWAY treatment for #2767 — do not merge - #3304
Closed
kovtcharov-amd wants to merge 2 commits into
Closed
Conversation
added 2 commits
September 2, 2026 09:15
`on.pull_request.branches` matches the PR's BASE branch, not its head, so `branches: [ main ]` meant "only when merging into main". Every PR stacked on a feature branch fell outside the filter and the jobs were never created — nothing failed, nothing showed as skipped, the checks page was simply missing them. #2599 merged email-agent changes with zero email tests, zero unit tests and zero lint behind a green page. Drops the filter from the 34 workflows that carried it. `paths:` filters and `push:` triggers are untouched, so a workflow still only runs for the code it covers and still only runs on main for pushes. `util/check_workflow_triggers.py` (wired into `lint.py --all`) fails the build if the filter comes back; lint.yml now watches `.github/workflows/**` so a workflows-only PR actually runs that gate.
github-actions
Bot
added
documentation
Collaborator
Author
|
Closing — throwaway verification PR, not intended to merge. The #2767 investigation it belonged to was stopped: stacked-branch CI coverage is by design, so there is nothing to fix. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Throwaway. Treatment arm for #2767: the same stacked PR WITH the fix applied. Expect the email/unit/lint checks to appear. Closing shortly.