Open
Conversation
Contributor
Author
|
Hello, where you able to take a look at this? Thank you |
ameshkov
requested changes
Mar 11, 2024
Owner
ameshkov
left a comment
ameshkov
left a comment
There was a problem hiding this comment.
I don't like the idea of adding OPT by default.
Let's do this only when do is true.
Contributor
Author
|
Thank you so much, something came up so I won't be able to check this for the next few days. Will get back to it as soon as I can |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting the do flag without having to explicitly enable an EDNS option.
Sometimes we would like to validate DNSSEC but not enable PADDING or any of the other options
Also this way padding won't override edns and they won't override subnet