🗑️ Remove duplicated ColorPalette class and related matplotlib dependency #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiulioRomualdi
requested review from
Giulero,
Copilot and
traversaro
and removed request for
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR removes a duplicated ColorPalette class and eliminates the matplotlib dependency by consolidating color palette functionality into the utils module. The change simplifies the codebase by removing redundancy and reduces dependencies.
- Removed redundant ColorPalette class from the plotter module
- Eliminated matplotlib dependency from setup.cfg
- Enhanced the existing ColorPalette in utils with improved type hints and additional methods
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| setup.cfg | Removed matplotlib dependency from install requirements |
| robot_log_visualizer/utils/utils.py | Enhanced ColorPalette class with type hints, added default color cycle, and new methods |
| robot_log_visualizer/plotter/pyqtgraph_viewer_canvas.py | Updated import and adapted code to use Color objects from utils ColorPalette |
| robot_log_visualizer/plotter/color_palette.py | Completely removed the duplicated ColorPalette class file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+193
to
+194
| palette_color = next(self._palette) | ||
| pen = pg.mkPen(palette_color.as_hex(), width=2) |
There was a problem hiding this comment.
[nitpick] The code now calls next(self._palette) and then palette_color.as_hex() separately. Consider using next(self._palette).as_hex() directly to avoid storing the intermediate Color object if it's not used elsewhere.
Suggested change
| palette_color = next(self._palette) | |
| pen = pg.mkPen(palette_color.as_hex(), width=2) | |
| pen = pg.mkPen(next(self._palette).as_hex(), width=2) |
traversaro
approved these changes
Oct 6, 2025
xela-95
pushed a commit
to xela-95/robot-log-visualizer
that referenced
this pull request
Oct 17, 2025
…ency (ami-iit#105) (cherry picked from commit fa0fcd1)
xela-95
pushed a commit
to xela-95/robot-log-visualizer
that referenced
this pull request
Oct 17, 2025
…ency (ami-iit#105) (cherry picked from commit fa0fcd1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminate the redundant ColorPalette class and its associated matplotlib dependency. The ColorPalette functionality is now integrated into the utils module.