fix(ui): move log severity off the row and onto the rail - #5112
Conversation
|
Reviewed the diff. No bugs found — small, self-contained change.
|
|
Try this PR without waiting for a release: Also on |
|
Bug: permalink highlight is masked on error/fatal rows when "Highlight error rows" is on (default)
Before this PR, all these rules were flat siblings under Fix: give Everything else looks solid: locales are all 16 files translated (not copy-pasted), the |
aa9858f to
63fd6cd
Compare
|
Blocking:
Bug:
|
The row tint added in #5058 washed error and warn lines in red and orange at full width, which fights the text sitting on top of it and reads as busy next to the zebra underneath. Severity now rides on the level marker only, so a single error line gets the same 3px rail a grouped entry gets instead of a 4px dot. Zebra drops from 4% to 2.5%, and the sidebar goes from 14px to 15px. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkDSHZUSAtWyqdeXrwq2Sw
Brings back a background on error and fatal rows at 5% instead of the 9% from #5058, and adds a toggle in settings for anyone who wants the field completely flat. Warn does not get one back: an orange wash on a routine retry line was the noisiest thing in the stream, and the orange dot already marks it. The Go field is a *bool with omitempty so a profile written before this setting existed stays silent instead of injecting a false that overrides the default of true. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkDSHZUSAtWyqdeXrwq2Sw
Zebra at 2.5%, the error tint at 5%, the level rail on single lines and the 15px sidebar all move pixels, so the homepage shots no longer matched. Regenerated through the compose image so the filenames keep their chromium-linux suffix. make int passes, 30 tests. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QkDSHZUSAtWyqdeXrwq2Sw
63fd6cd to
a3243bc
Compare
|
Reviewed the diff. No bugs found — the Minor:
|
Picks up the feedback in #5103.
The row tint from #5058 washed error and warn lines in red and orange across the full width. At drawer width that's a lot of saturated background under text you're trying to read, and it stacks on top of the zebra striping, so the stream reads busy.
Severity now rides primarily on the level marker. A single error line gets the same 3px rail a grouped entry already gets, rather than a 4px dot that was too small to carry it alone. The row background is a hint on top of that:
The Go side stores it as a
*boolwithomitempty. A plain bool would serialize as false for every profile written before this setting existed, and that false gets injected into the page and overrides the frontend default of true, silently shipping the feature off.The tailwind class cleanup that was here has moved to #5113, which also adds the linter that catches it. Expect a small conflict in LogLevel.vue and the EventSource snapshot between the two, whichever lands second.
All 16 locale files carry the two new keys, translated.
Tested by hand in dark mode against a container emitting a fixed mix of info, debug, warn, single line errors and multi line panics, with the toggle flipped both ways and the setting confirmed to round trip through the server profile.
pnpm typecheck,pnpm test(373) andgo test -race ./internal/web/...pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01QkDSHZUSAtWyqdeXrwq2Sw