[pull] main from forem:main - #339
Merged
Merged
Conversation
* Add admin CRUD endpoints for surveys API * Address pull request review comments (linting, schema validation, missing responses) * Fix survey_url test assertion flakiness due to subforem host context
* Bust org edge cache when organization pages are saved Organization pages render at the org profile URLs (/:org_slug for the readme, /:org_slug/:suffix for custom pages, and both again on the org's custom domain), but Page#bust_cache only busted /page/:slug and /:slug. Saving a page from /:org_slug/settings/pages left the org profile and custom-domain responses stale at the edge. Thread the page's organization through Pages::BustCacheWorker into EdgeCache::BustPage, which now also purges the organization's surrogate key (with the org profile path as the non-Fastly fallback). All org page responses carry that key, so one purge covers every URL variant. The worker arg is optional, keeping already-enqueued jobs compatible. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Keep single-arg enqueue for non-org page cache busts BustCacheBaseWorker's until_executing lock digests on job args, so always appending a nil organization_id would stop new jobs from coalescing with the historical single-arg form. Only pass the second arg for organization pages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* Add admin CRUD endpoints for surveys API * Address pull request review comments (linting, schema validation, missing responses) * Fix survey_url test assertion flakiness due to subforem host context * Implement AI-filled survey email context * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Move AI email context generation to background job and address PR review comments --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…23661) * Support custom domains as canonical links on organization show pages * Clear custom_domain cache in bust_cache to ensure test isolation and prevent stale cache * Check in-memory organization before MemoryFirstCache in URL.article to prevent stale test cache hits
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )