[ADD] price with minor units param#620
Merged
Merged
Conversation
rasa04
force-pushed
the
cents
branch
2 times, most recently
from
March 3, 2026 11:40
e0baa7b to
1869540
Compare
Author
|
Author
|
bessudnov
reviewed
Mar 3, 2026
| * @param int|float|null $price | ||
| */ | ||
| public function setPrice(?int $price): self | ||
| public function setPrice($price): self |
Collaborator
There was a problem hiding this comment.
нужно добавить проверку на типы внутри метода, если убираем тип
bessudnov
reviewed
Mar 3, 2026
| public function testToApiUsesNumericPriceFieldForIntegerInput(): void | ||
| { | ||
| $this->assertSame( | ||
| ['price' => 100.0, 'request_id' => '0'], |
Collaborator
There was a problem hiding this comment.
добавь тесты, если строку передадут, массив и тд)
Author
|
bessudnov
reviewed
Apr 13, 2026
| return isset($this->price) ? (int)$this->price : null; | ||
| } | ||
|
|
||
| public function getPriceWithMinorUnits(): ?float |
Collaborator
There was a problem hiding this comment.
нужен коммент, что в данный момент это только для kommo
а также поднять версию либы, там была константа
1.16.0 поставить
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.