Add more context to the no request sent messages in callbacks #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philip-peterson
suggested changes
Jul 16, 2018
src/amplitude-client.js
Outdated
| if (!this._apiKeySet('identify()')) { | ||
| if (type(opt_callback) === 'function') { | ||
| opt_callback(0, 'No request sent'); | ||
| opt_callback(0, 'No request sent', 'API key is not set'); |
There was a problem hiding this comment.
I'd make it an object with a single key, in case we decide to extend the information even more in the future.
blazzy
force-pushed
the
no-request-sent-context
branch
from
e605d1d to
5f0c71d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.