Skip to content

Add Components Documentation Chinese translation#4643

Merged
matthiasrohmer merged 5 commits intoampproject:futurefrom
sss55b:future
Sep 24, 2020
Merged

Add Components Documentation Chinese translation#4643
matthiasrohmer merged 5 commits intoampproject:futurefrom
sss55b:future

Conversation

@sss55b
Copy link
Copy Markdown
Contributor

@sss55b sss55b commented Sep 22, 2020

Hello, I have translated 9 documents into Chinese!

@google-cla google-cla bot added the cla: yes label Sep 22, 2020
Copy link
Copy Markdown
Collaborator

@matthiasrohmer matthiasrohmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thanks a lot! I can't say anything about the actual translation work, but this technically looks good except the one comment I added.

/cc @patrickkettner, @CrystalOnScript

Copy link
Copy Markdown
Collaborator

@matthiasrohmer matthiasrohmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙂

@matthiasrohmer matthiasrohmer merged commit 586f900 into ampproject:future Sep 24, 2020
robinvanopstal added a commit that referenced this pull request Sep 24, 2020
* future:
  Add Components Documentation  Chinese translation (#4643)
robinvanopstal added a commit that referenced this pull request Sep 24, 2020
* future:
  Pixi - Fix layout bugs (#4656)
  Add Components Documentation  Chinese translation (#4643)
  Redirects for pixi (#4647)
  Adding tappable as a story creation tool (#4599)
  Update dependency rcs-core to v3.5.0 (#4663)
  🚑 Fix formatting issues in translated documents
robinvanopstal added a commit that referenced this pull request Sep 24, 2020
* future: (34 commits)
  Pixi - Add next advice button  (#4658)
  Reflect Verizon Media and Yahoo Mail branding (#4576)
  🐛 Pixi - Wrap code snippets (#4679)
  ♻️ Beautify scss (#4678)
  🐛 Fix overlapping tooltips (#4677)
  🚑 Fix formatting issues in translated documents.
  💄 Adjust basic metric border color
  Pixi - Fix layout bugs (#4656)
  Add Components Documentation  Chinese translation (#4643)
  Redirects for pixi (#4647)
  Adding tappable as a story creation tool (#4599)
  Update dependency rcs-core to v3.5.0 (#4663)
  🚑 Fix formatting issues in translated documents
  Add aria label to scroll to top button (#4674)
  🎨 Let remote documents not break build (#4676)
  [AR] Translations - documentation (Alconost) (#4611)
  [AR] Translations - documentation (Alconost) (#4612)
  [ID] Translations - documentation (Alconost) (#4623)
  [ID] Translations - documentation (Alconost) (#4624)
  [ID] Translations - documentation (Alconost) (#4625)
  ...

# Conflicts:
#	frontend/scss/components/atoms/pixi-scale.scss
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants