Pixi - Add next advice button by robinvanopstal · Pull Request #4658 · ampproject/amp.dev

robinvanopstal · 2020-09-23T14:03:35Z

No description provided.

* future: Pixi - Fix metric loading indicator (#4556)

* future: 🐛 Fix typo in StatusIntroView (#4603) 🐛 Do not take AMP.getState returning something for granted (#4601) Update dependency codemirror to v5.58.0 (#4598) a11y radio-selector (#4596) Prefer visibility over display CSS property (#4582) 🐛 Gracefully handle experiments without a descriptive name in playground (#4592) Pixi- Fix cls decimal values (#4594)

# Conflicts: # frontend/scss/components/molecules/pixi-recommendations-item.scss

* future: Revert "♻️ Stop replacing HTML entities in Pixi (#4649)" (#4655)

google-cla · 2020-09-23T14:03:45Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-23T14:09:23Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-23T14:10:29Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla · 2020-09-23T14:12:20Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

matthiasrohmer · 2020-09-23T14:13:10Z

@googlebot I consent.

pages/content/pixi/index.md

pixi/src/ui/recommendations/RecommendationsView.js

frontend/templates/views/partials/pixi/recommendations-item.j2

Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>

…ct/amp.dev into feature/pixi-add-scroll-to-btns * 'feature/pixi-add-scroll-to-btns' of github.com:ampproject/amp.dev: Update pixi/src/ui/recommendations/RecommendationsView.js

* future: [AR] Translations - documentation (Alconost) (#4611) [AR] Translations - documentation (Alconost) (#4612) [ID] Translations - documentation (Alconost) (#4623) [ID] Translations - documentation (Alconost) (#4624) [ID] Translations - documentation (Alconost) (#4625) [ID] Translations - documentation (#4626) [ID] Translations - documentation (Alconost) (#4628) [ID] Translations - documentation (Alconost) (#4629) [ID] Translations - documentation (Alconost) (#4630) [ID] Translations - documentation (Alconost) (#4632) [ES] Translations - documentation (Alconost) (#4657) [ES] Translations - more guides and tutorials (Alconost) (#4660) [ES] Translations - guides and tutorials/learn (Alconost) (#4661) [ES] Translations - guides and tutorials (Alconost) (#4673) Add Verizon media go link (#4637) Pixi: Remove GH issue link from status when there are recommendations to give (#4672) Sample for protocol adapter (#4588) Pixi: Add inline explainer for lagging field data (#4609) fix typo

Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>

* future: Add aria label to scroll to top button (#4674) 🎨 Let remote documents not break build (#4676)

* future: Pixi - Fix layout bugs (#4656) Add Components Documentation Chinese translation (#4643) Redirects for pixi (#4647) Adding tappable as a story creation tool (#4599) Update dependency rcs-core to v3.5.0 (#4663) 🚑 Fix formatting issues in translated documents

* future: 🚑 Fix formatting issues in translated documents. 💄 Adjust basic metric border color

… height

* future: ♻️ Beautify scss (#4678) 🐛 Fix overlapping tooltips (#4677) # Conflicts: # frontend/scss/components/molecules/pixi-basic-metric.scss

* future: (34 commits) Pixi - Add next advice button (#4658) Reflect Verizon Media and Yahoo Mail branding (#4576) 🐛 Pixi - Wrap code snippets (#4679) ♻️ Beautify scss (#4678) 🐛 Fix overlapping tooltips (#4677) 🚑 Fix formatting issues in translated documents. 💄 Adjust basic metric border color Pixi - Fix layout bugs (#4656) Add Components Documentation Chinese translation (#4643) Redirects for pixi (#4647) Adding tappable as a story creation tool (#4599) Update dependency rcs-core to v3.5.0 (#4663) 🚑 Fix formatting issues in translated documents Add aria label to scroll to top button (#4674) 🎨 Let remote documents not break build (#4676) [AR] Translations - documentation (Alconost) (#4611) [AR] Translations - documentation (Alconost) (#4612) [ID] Translations - documentation (Alconost) (#4623) [ID] Translations - documentation (Alconost) (#4624) [ID] Translations - documentation (Alconost) (#4625) ... # Conflicts: # frontend/scss/components/atoms/pixi-scale.scss

caroqliu

Ah it looks like this comment never got sent, I'll send a PR with this suggested change as well. Sorry about that!

caroqliu · 2020-09-23T20:51:11Z

pixi/src/ui/recommendations/RecommendationsView.js

  }
+
+  onClickNext(recommendation) {
+    recommendation.classList.remove('expanded');


Suggested change

recommendation.classList.remove('expanded');

recommendation.classList.remove('expanded');

recommendation.setAttribute('aria-expanded', 'false');

robinvanopstal and others added 10 commits September 18, 2020 11:18

♻️ Code cleanings

a18ee39

✨ Add next advide button markup

240dccf

✨ Add logic for next advice button

d2dda69

🐛 Fix broken icon due to cloneNode

bb5b9dc

Merge branch 'future' into feature/pixi-add-scroll-to-btns

276b140

* future: Pixi - Fix metric loading indicator (#4556)

Merge branch 'future' into feature/pixi-add-scroll-to-btns

02d518e

# Conflicts: # frontend/scss/components/molecules/pixi-recommendations-item.scss

🐛 Correctly anchor next advise below fixed header

3251957

Merge branch 'future' into feature/pixi-add-scroll-to-btns

fddc1b4

* future: Revert "♻️ Stop replacing HTML entities in Pixi (#4649)" (#4655)

🐛 Fix broken icon

46282e3

google-cla bot added the cla: no label Sep 23, 2020

🚨 Fix lint warnings

201f0a5

google-cla bot added cla: yes and removed cla: no labels Sep 23, 2020

caroqliu reviewed Sep 23, 2020

View reviewed changes

pages/content/pixi/index.md Outdated Show resolved Hide resolved

pixi/src/ui/recommendations/RecommendationsView.js Show resolved Hide resolved

caroqliu reviewed Sep 23, 2020

View reviewed changes

pixi/src/ui/recommendations/RecommendationsView.js Outdated Show resolved Hide resolved

caroqliu reviewed Sep 23, 2020

View reviewed changes

frontend/templates/views/partials/pixi/recommendations-item.j2 Outdated Show resolved Hide resolved

robinvanopstal and others added 8 commits September 24, 2020 08:28

Update pixi/src/ui/recommendations/RecommendationsView.js

879f133

Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>

👌 Set role="region" on item-body

2d1936a

Merge branch 'feature/pixi-add-scroll-to-btns' of github.com:ampproje…

3cbfa31

…ct/amp.dev into feature/pixi-add-scroll-to-btns * 'feature/pixi-add-scroll-to-btns' of github.com:ampproject/amp.dev: Update pixi/src/ui/recommendations/RecommendationsView.js

💬 Update "Next advice" text

646c33f

Update pixi/src/ui/recommendations/RecommendationsView.js

ccae5de

Co-authored-by: Caroline Liu <10456171+caroqliu@users.noreply.github.com>

Merge branch 'future' into feature/pixi-add-scroll-to-btns

91e7550

* future: Add aria label to scroll to top button (#4674) 🎨 Let remote documents not break build (#4676)

♻️ Remove duplicate code

f19474e

robinvanopstal added 4 commits September 24, 2020 10:39

♻️ Beautify

0d50193

Merge branch 'future' into feature/pixi-add-scroll-to-btns

ec50e59

* future: 🚑 Fix formatting issues in translated documents. 💄 Adjust basic metric border color

🐛 Add wrapping container in recommendations item to correctly set its…

3f68c23

… height

robinvanopstal requested review from caroqliu and matthiasrohmer September 24, 2020 10:04

robinvanopstal and others added 3 commits September 24, 2020 14:49

Merge branch 'future' into feature/pixi-add-scroll-to-btns

1c3da26

* future: ♻️ Beautify scss (#4678) 🐛 Fix overlapping tooltips (#4677) # Conflicts: # frontend/scss/components/molecules/pixi-basic-metric.scss

Merge branch 'future' into feature/pixi-add-scroll-to-btns

3f3eff9

🐛 Beautify scss

a90063b

matthiasrohmer merged commit 0b2129c into future Sep 24, 2020

matthiasrohmer deleted the feature/pixi-add-scroll-to-btns branch September 24, 2020 12:54

caroqliu reviewed Sep 24, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pixi - Add next advice button #4658

Pixi - Add next advice button #4658
matthiasrohmer merged 26 commits intofuturefrom
feature/pixi-add-scroll-to-btns

robinvanopstal commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

matthiasrohmer commented Sep 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caroqliu left a comment

Uh oh!

caroqliu Sep 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	recommendation.classList.remove('expanded');
	recommendation.classList.remove('expanded');
	recommendation.setAttribute('aria-expanded', 'false');

Conversation

robinvanopstal commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

google-cla bot commented Sep 23, 2020

Uh oh!

matthiasrohmer commented Sep 23, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caroqliu left a comment

Choose a reason for hiding this comment

Uh oh!

caroqliu Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants