Skip to content

✨ Render resource hints in related recommendations#4701

Merged
matthiasrohmer merged 4 commits intofuturefrom
feature/pixi/image-recommendations
Sep 25, 2020
Merged

✨ Render resource hints in related recommendations#4701
matthiasrohmer merged 4 commits intofuturefrom
feature/pixi/image-recommendations

Conversation

@matthiasrohmer
Copy link
Copy Markdown
Collaborator

@matthiasrohmer matthiasrohmer commented Sep 25, 2020

Adds needed functionality to pass Lighthouse audit details through to the recommendation view and there rudimentarily renders them.

Bildschirmfoto 2020-09-25 um 12 28 23

Works towards #4666.

@google-cla google-cla bot added the cla: yes label Sep 25, 2020
caroqliu
caroqliu approved these changes Sep 25, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@caroqliu caroqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add Images to consider: before the bulleted list? Over to @nainar to approve visual as well.

@matthiasrohmer
Copy link
Copy Markdown
Collaborator Author

matthiasrohmer commented Sep 25, 2020

Merging to get the initial concept in, happy to tune in further PRs! 🙂

@matthiasrohmer matthiasrohmer merged commit fd47db9 into future Sep 25, 2020
@matthiasrohmer matthiasrohmer deleted the feature/pixi/image-recommendations branch September 25, 2020 13:55
robinvanopstal added a commit that referenced this pull request Sep 25, 2020
@robinvanopstal
Merge branch 'future' into fix/pixi-stage-title-positioning
29eaf66 
* future:
  ✨ Render resource hints in related recommendations (#4701)
  ♻️ Do not rely on AMP.getState to get Pixi sharing URL (#4707)
  🔧  Enable AGGRESSIVE_BUNDLE for Pixi build (#4703)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caroqliu caroqliu caroqliu approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthiasrohmer @caroqliu