🔧 Enable AGGRESSIVE_BUNDLE for Pixi build#4703
Merged
matthiasrohmer merged 2 commits intofuturefrom Sep 25, 2020
Merged
Conversation
caroqliu
approved these changes
Sep 25, 2020
Collaborator
Author
|
Created #4704 for further discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables babel transpilations for Pixi as all JS features we are using (
async/awaitmainly) are gracefully handled by Closure Compiler already. This brought down bundle size from 110 KiB to 98.7 KiB.Additionally this PR enables CCs'
AGGRESSIVE_BUNDLEmode which surprisingly didn't require much work. Savings aren't that big though, it brought down bundle size to 98.2 KiB with slight DX degredations.We could even further bring it down to by only supporting ES2015 capable browsers (82.4KB) but this would exclude IE11.
Biggest optimization would be to get rid of
markedthough, without it and ES2015+ browser support we would land at 48.6 KiB. Creating a follow-up issue to discuss this.