🚀 Report cls-fcp and cls-ofv to compare with cls#33207
Merged
kristoferbaxter merged 4 commits intoampproject:masterfrom Mar 11, 2021
Merged
🚀 Report cls-fcp and cls-ofv to compare with cls#33207kristoferbaxter merged 4 commits intoampproject:masterfrom
kristoferbaxter merged 4 commits intoampproject:masterfrom
Conversation
rcebulko
requested review from
erwinmombay,
jridgewell,
kristoferbaxter and
samouri
kristoferbaxter
approved these changes
Mar 11, 2021
Contributor
kristoferbaxter
left a comment
kristoferbaxter
left a comment
There was a problem hiding this comment.
This looks good to me. Good to get another reviewer @ampproject/wg-performance?
erwinmombay
reviewed
Mar 11, 2021
erwinmombay
approved these changes
Mar 11, 2021
samouri
approved these changes
Mar 11, 2021
kristoferbaxter
approved these changes
Mar 11, 2021
Contributor
kristoferbaxter
left a comment
kristoferbaxter
left a comment
There was a problem hiding this comment.
Approval for bundle-size.
kristoferbaxter
changed the title
ampprojectbot
pushed a commit
that referenced
this pull request
Mar 11, 2021
* Report cls-fcp and cls-vis * Add tests * Add issue # * rename cls-vis to cls-ofv Co-authored-by: Erwin Mombay <erwinm@google.com> (cherry picked from commit bff78f6)
Contributor
Author
|
@erwinmombay Thanks for pushing this across the finish line! |
ampprojectbot
pushed a commit
that referenced
this pull request
Mar 12, 2021
* Report cls-fcp and cls-vis * Add tests * Add issue # * rename cls-vis to cls-ofv Co-authored-by: Erwin Mombay <erwinm@google.com> (cherry picked from commit bff78f6)
12 tasks
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Mar 15, 2021
* 'master' of github.com:ampproject/amphtml: (536 commits) ✨ Send extension versions from AMPHTML ads to FIE (ampproject#33190) Update amp-autocomplete test output file (ampproject#33216) ✨ Changing Inline Page Attachment Button UI (ampproject#33142) ✨Launch no-signing (ampproject#33229) ♻️ Add logic for story ad page manager. (ampproject#33201) Migrate Bento components to V1 (ampproject#32974) 📦 Update dependency mocha to v8.3.2 (ampproject#33234) 📦 Update build system devDependencies (ampproject#33178) 🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment (ampproject#33196) Fix amp-video amp_video_quality parameter name. (ampproject#33227) 🏗 Guard access to `BASH_ENV` during CircleCI push builds (ampproject#33231) 🏗 Clean up CircleCI merge SHA logic (ampproject#33215) 📦 Update dependency karma to v6.1.2 (ampproject#33151) 🏗 Ensure up-to-date and clean `package-lock.json` before running any CI job (ampproject#33223) Ensure that pre-stubbing always happens before the first element is upgraded (ampproject#33212) 🏗 Restore `package-lock.json` to `lockfileVersion = 1` (ampproject#33222) Fixed text align of buttons (ampproject#33217) [amp-story] ♿ Add label for next story and add i18n for pagination buttons (ampproject#33205) [amp-story-player] 📖 Rename skip-next control to skip-to-next (ampproject#33164) 🚀 Report cls-fcp and cls-vis to compare with cls (ampproject#33207) ...
muuki88
pushed a commit
to highfivve/amphtml
that referenced
this pull request
Mar 15, 2021
* Report cls-fcp and cls-vis * Add tests * Add issue # * rename cls-vis to cls-ofv Co-authored-by: Erwin Mombay <erwinm@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Data suggests some CLS violations are occurring either before FCP, before iframe visibility, or both. This PR adds reporting for two new metrics: