🖍 [amp story shopping] Prevent shopping tag dot and image from shrinking#37149
Merged
processprocess merged 2 commits intoampproject:mainfrom Dec 20, 2021
Merged
🖍 [amp story shopping] Prevent shopping tag dot and image from shrinking#37149processprocess merged 2 commits intoampproject:mainfrom
processprocess merged 2 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet! These files were changed: |
coreymasanto
approved these changes
Dec 8, 2021
| justify-content: center !important; | ||
| background-color: rgba(0, 0, 0, 0.6) !important; | ||
| border-radius: 100% !important; | ||
| flex-shrink: 0 !important; |
Contributor
There was a problem hiding this comment.
Would setting flex-shrink to 0 cause other elements within the shopping tag (e.g., any text) to shrink in order to give space to the dot and image? I'm not familiar with flex-shrink, so I'm just basing my question on what I read here.
Contributor
Author
There was a problem hiding this comment.
This is correct and intended since the text area can grow and shrink based on content.
gmajoulet
approved these changes
Dec 9, 2021
Contributor
|
Is there a set of visual diff tests that could decrease the likelihood of this regressing? |
Contributor
Author
Yes, it previously did not have a use-case to test this. It's now been updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents tag dot and image from shrinking when there is text. In the tag.
Related to #37112
Text formatting will be added in #37039