Skip to content

🌐 amp story shopping "Shop now" CTA casing#38096

Merged
processprocess merged 1 commit intoampproject:mainfrom
processprocess:cta
Apr 20, 2022
Merged

🌐 amp story shopping "Shop now" CTA casing#38096
processprocess merged 1 commit intoampproject:mainfrom
processprocess:cta

Conversation

@processprocess
Copy link
Contributor

Change casing pattern to match other CTA text such as "Swipe up" for attachments.

Fixes #38082

@processprocess processprocess requested a review from jshamble April 13, 2022 17:06
@amp-owners-bot
Copy link

amp-owners-bot bot commented Apr 13, 2022

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story-shopping/amp-story-shopping.md
extensions/amp-story/1.0/_locales/en-GB.json
extensions/amp-story/1.0/_locales/en.json

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/en-GB.json
extensions/amp-story/1.0/_locales/en.json

@jshamble
Copy link
Contributor

2 really minor nits, both not big deals at all - I'll leave it up to you if you want to fix these.

a) The Images in the shopping documentation have not been updated and are still showing Shop Now, they could be updated to show Shop now (after the changes, with the lowercase n)

b) If we are being particular of the casing for the documentation, I don't see why we should not also be particular with the casing of the "Buy now" button, currently some parts of the documentation are inconsistent with the casing for Buy now.

@processprocess
Copy link
Contributor Author

2 really minor nits, both not big deals at all - I'll leave it up to you if you want to fix these.

a) The Images in the shopping documentation have not been updated and are still showing Shop Now, they could be updated to show Shop now (after the changes, with the lowercase n)

b) If we are being particular of the casing for the documentation, I don't see why we should not also be particular with the casing of the "Buy now" button, currently some parts of the documentation are inconsistent with the casing for Buy now.

Great catch. Keeping these consistent is every important. I'll make these changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amp-story-shopping] Make call to action case consistent

4 participants