🏗 Partial updates for core devDependencies#39765
Merged
danielrozenberg merged 4 commits intoampproject:mainfrom Jan 26, 2024
Merged
🏗 Partial updates for core devDependencies#39765danielrozenberg merged 4 commits intoampproject:mainfrom
danielrozenberg merged 4 commits intoampproject:mainfrom
Conversation
danielrozenberg
force-pushed
the
core-devdep-partial-c-d
branch
3 times, most recently
from
129b80f to
e1f9d8b
Compare
erwinmombay
approved these changes
Jan 25, 2024
danielrozenberg
force-pushed
the
core-devdep-partial-c-d
branch
from
e1f9d8b to
1578197
Compare
eszponder
pushed a commit
to krzysztofequativ/amphtml
that referenced
this pull request
Apr 22, 2024
* Remove CircleCI debugging code from unit.js * Upgrade `commander` to v11.1.0 * Upgrade `dedent` to v1.5.1 * Upgrade `typescript` to v5.3.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates code devDependencies that require non-trivial changes to the codebase:
dedent- explicitly requires that we import itsdefaultcommander- requires that we importPrograminstead of the default exporttypescript- requires a minor type definition change insrc/preact/component/types.d.tsThis PR also removes the
why-is-node-runningpackage and the debugging code that used it, which should fix the brokenamp --helpcommand