🐛 Prevent prototype pollution in amp-analytics mergeObjects#40522
Open
madib06ops wants to merge 1 commit into
Open
🐛 Prevent prototype pollution in amp-analytics mergeObjects#40522madib06ops wants to merge 1 commit into
madib06ops wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mergeObjects merges a remote analytics config fetched via res.json() (and the inline config) into the page config, but it never skips the
__proto__key. A config endpoint returning{"__proto__": {...}}makes the recursive merge readto['__proto__'], which resolves to Object.prototype, and the following assignments pollute it for every object on the page. Skip__proto__,constructorandprototypeinside the merge loop so untrusted config can't reach the prototype chain. Added a regression test under the existingmergeObjectsblock.