🐛 Fix client hints URL parameter construction in mapp_intelligence#40523
Open
StephanGuenther wants to merge 1 commit into
Open
🐛 Fix client hints URL parameter construction in mapp_intelligence#40523StephanGuenther wants to merge 1 commit into
StephanGuenther wants to merge 1 commit into
Conversation
Consolidate separate param-name and value variables into single segment variables that include the & separator only when the value is present, preventing malformed &= fragments in the tracking URL when client hints are disabled. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation used separate variables for parameter names (
uachModelParam) and values (uachModelValue), assembled inclientHintParamswith a hardcoded&separator. When client hints were disabled, this produced malformed URL fragments like&=in the tracking request.This change consolidates the six variables into three segment variables (
uachModelSegment,uachPlatformSegment,uachPlatformVersionSegment) that each include the&KEY="VALUE"unit as a whole — the&separator is now inside the$IFcondition and only appears when the value is actually present.The test expectations in
vendor-requests.jsonare updated accordingly.