Improve social icons in the footer#32
Conversation
- Increased spacing between icons (gap-6) - Increased icon size (text-2xl) - Ensured circular hover effect using isIconOnly and rounded-full - Cleaned up legacy CSS classes on buttons
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
| const socialProfiles = propsProfiles || profiles; | ||
| return ( | ||
| <div className="flex flex-row justify-center gap-2"> | ||
| <div className="flex flex-row justify-center gap-6"> |
There was a problem hiding this comment.
Changed the gap to 4 as requested.
| onPress={() => window.open(profile.link, "_blank", "noreferrer")} | ||
| > | ||
| {profile.icon} | ||
| <span className="text-2xl">{profile.icon}</span> |
There was a problem hiding this comment.
unnecessary span? keep text-2xl in the enclosing button class
There was a problem hiding this comment.
Removed the unnecessary span and moved the text-2xl class to the Button component.
- Changed gap from 6 to 4 - Moved text-2xl to Button className and removed span wrapper
|
amrabed
merged commit 715323e
into
upgrade-next-tailwind-heroui-15687692994589951899
1 participant
I have improved the social icons in the footer to make them look more professional.
Key changes:
gap-2togap-6.text-2xl.isIconOnlyprop androunded-fullclass to the HeroUIButtoncomponent to ensure a perfect circular hover effect.min-w-0 p-2 h-autoclasses that were causing the elliptical shape.I verified the changes visually using Playwright and ran linting to ensure code quality.
PR created automatically by Jules for task 5275246825039705590 started by @amrabed