Fix dark mode switch responsiveness#96
Conversation
HeroUI v3 (React Aria Components) requires custom children within a Switch to be wrapped in Switch.Content to ensure click/tap interactions are correctly captured. This fixes the issue where the dark mode switch was not responsive.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
amrabed
deleted the
fix-dark-mode-switch-responsiveness-1047180901251550173
branch
1 participant
The dark mode switch in the footer was not responding to clicks because it was missing the required
Switch.Contentwrapper for custom children in HeroUI v3. This PR wraps theSwitch.Controland its children inSwitch.Content, restoring the toggle functionality.Verification:
pnpm exec tsc --noEmitto ensure type safety.pnpm exec vitest run src/contexts/contexts.test.tsxto verify theme logic.darkclass on thehtmlelement.PR created automatically by Jules for task 1047180901251550173 started by @amrabed