Skip to content

Add common mount options and fix most of the tests for fuse-t#3

Merged
anacrolix merged 2 commits into
anacrolix:masterfrom
macos-fuse-t:master
Aug 13, 2023
Merged

Add common mount options and fix most of the tests for fuse-t#3
anacrolix merged 2 commits into
anacrolix:masterfrom
macos-fuse-t:master

Conversation

@macos-fuse-t

Copy link
Copy Markdown

go test ./... still freezes because of concurrency issues in the testing infra. However most of the tests are passing when running one by one.

Signed-off-by: Alex Fishman <alex@fuse-t.org>
@anacrolix
anacrolix merged commit e63941e into anacrolix:master Aug 13, 2023
@anacrolix

Copy link
Copy Markdown
Owner

I made it store the backend per Conn, and fixed some variable scoping.

The race is caused by checking the ready chan after mounting for a MountError. The FUSE-T code isn't synchronizing the same way the OSXFUSE stuff does. I simple attempt to fix it didn't work for me, it needs a deeper look.

AFAICT, there might be some issues with macfuse 4.5 not handling some mount flags, even if I apply the minimal fixes since I forked from zegl, those issues still come up. This is a problem with the OSXFUSE implementation however, and probably not a concern for FUSE-T.

@anacrolix

Copy link
Copy Markdown
Owner

I am using the tests in github.com/anacrolix/torrent/fs as the ultimate screen for whether the different fuse backends are working. Currently both backends (OSXFUSE/MacFUSE, and FUSE-T) work on Mac.

@anacrolix anacrolix mentioned this pull request Aug 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants